Remove unneeded max-height from text-menubar which caused a bug#8311
Remove unneeded max-height from text-menubar which caused a bug#8311
Conversation
JuliaKirschenheuter
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@JuliaKirschenheuter Based on the comment this setting was important for mobile use. Did you try it on a mobile screen size? |
yes, this changes for mobile screens are obsolet. But double-checking is warm welcome! |
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes seem good. Did not test - trust you on that.
… a bug Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
mejo-
force-pushed
the
fix/1395-notes-Layout-issues
branch
from
12ca7f3 to
2d4c708
Compare
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
I tested in Collectives and standalone Text with desktop and mobile view and indeed it fixes the focus active borders being cut off (Collectives desktop) or overlaying the separation line to content (standalone mobile).
|
/backport to stable33 |
|
/backport to stable32 |
1 similar comment
|
/backport to stable32 |
3 participants
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)